#2655 update alpha gamma drop down position #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Sep 24, 2024
|
One caveat to this- this UI should always be enabled. We have some special handling for alpha gamma that allows it to function even on no-mod objects through a special message that was introduced in the alpha params branch. |
|
Oh, I see. Reverted that change, so this control is always enabled. |
akleshchev
approved these changes
Sep 24, 2024
maxim-productengine
merged commit d362cff
into
geenz/feat/legacy-alpha-params
6 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also minor changes: disable drop down when the object is not editable and enable correct text label otherwise.
