#1080 BugSplat Crash: LLAppViewer::initStrings() - show crash reason #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
There is no point to call LL_WARNS() << crash_reason << LL_ENDL;, LL_ERRS will already print that to logs.
P.S. Also might be a good idea to remove 'Please reinstall' part of the LL_ERRS, user doesn't see that unless user goes to check logs, showMissingFiles() already asks user to reinstall.
LLGuru
force-pushed
the
guru/viewer-1080-crash-initStrings
branch
from
f3747cd to
4ab8362
Compare
LLGuru
force-pushed
the
guru/viewer-1080-crash-initStrings
branch
from
4ab8362 to
2f1c169
Compare
Thanks. I added that part a long time ago when I though that user is capable of seeing those LL_ERRS 😅, but it's invisible to users. |
marchcat
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause seems to be on the client side
For helping the user to understand the actual crash reason
we could include it's short description into the crash message