viewer#1200 Avatar rotates 360 degrees when viewed from the top and below #1240
Conversation
indra/newview/llagent.cpp
Outdated
| @@ -1453,48 +1453,70 @@ LLVector3 LLAgent::getReferenceUpVector() | |||
| return up_vector; | |||
| } | |||
|
|
|||
|
|
|||
| #pragma optimize("", off) | |||
There was a problem hiding this comment.
?
I felt that I would forget to remove it :-)
LLGuru
force-pushed
the
guru/viewer-1200-avatar-rotates
branch
from
3b04c12 to
2fb93f7
Compare
| @@ -112,6 +112,7 @@ class LLAgentCamera | |||
| //-------------------------------------------------------------------- | |||
| public: | |||
| void switchCameraPreset(ECameraPreset preset); | |||
| ECameraPreset getCameraPreset() const { return mCameraPreset; } | |||
There was a problem hiding this comment.
See the second file in this commit
There was a problem hiding this comment.
And what would happen with custom presets? Like a rear view, but slightly to the side?
There was a problem hiding this comment.
I just want to mention that all 3 "default" presets (Front, Rear, Side) can be overwritten. For example, you can set the values of 'Rear' and 'Side' to be the same as 'Front'. Basically, they are almost the same as 'custom' presets, but have their own buttons and default values, stored in the file.
There was a problem hiding this comment.
I believe the current bug relates to the default preset settings, and the fix as well
We will solve the issues with custom presets when having bugs relates to them, not before
There was a problem hiding this comment.
So in this case, it looks like those bugs will appear in the very first round of testing. Why wait, then?
There was a problem hiding this comment.
So in this case, it looks like those bugs will appear in the very first round of testing. Why wait, then?
Nothing is changed for custom presets
If we don't have bugs with them right now, why should they appear after this change?
There was a problem hiding this comment.
I meant something like that:
- Open 'Camer controls'
- Select 'Front view'
- Click 'Save as preset' button
- Choose 'Replace a preset' and select 'Rear'
- (then repeat and select 'Side')
- Click 'Save as preset' button once again
- And save as new preset.
After that the bug will be reproducible on all camera preset views, including REAR, GROUP, CUSTOM.
There was a problem hiding this comment.
Test plan for QA now includes testing presets, so I'm tentatively approving this.
There was a problem hiding this comment.
If the user explicitly sets incorrect preset settings, the bugs like this are expected, but they won't be treated as bugs
For example, if user choses the color scheme with white color for font and background, the text becomes unreadable, but this is not a bug, yes? :-)
indra/newview/llagent.cpp
Outdated
| } | ||
| } | ||
| // don't let user pitch if pointed almost all the way down or up | ||
| if (gAgentCamera.getCameraMode() == CAMERA_MODE_THIRD_PERSON || |
There was a problem hiding this comment.
Why did you add this cheack? Won't this negatively affect avatar customization mode which isn't listed?
There was a problem hiding this comment.
Because each preset requires different checks
There was a problem hiding this comment.
The avatar customization mode won't be affected because it doesn't use vertical angles close to 1 and 179
There was a problem hiding this comment.
And CAMERA_MODE_FOLLOW? That's a mode where script overrides control over camera and otherwise acts as a CAMERA_MODE_THIRD_PERSON, doesn't appear to affect mouselook
There was a problem hiding this comment.
CAMERA_MODE_FOLLOW also doesn't seem to use critical values of the vertical angle (1 or 179)
There was a problem hiding this comment.
I checked and it behaves exactly like CAMERA_MODE_THIRD_PERSON in most cases with the kart, except camera follows behind you in some cases. But it depends on a script, ex: a rocket or a plane can easily trow your camera high up so I suggest checking those cases or at least providing a test plan that would cover them.
There was a problem hiding this comment.
With CAMERA_MODE_FOLLOW your camera could rotate any directions without any action from your side
So this bug doesn't make sense for CAMERA_MODE_FOLLOW
When the vertical angle takes critical values 1 or 179, camera could rotate, and nobody treats this like a bug
LLGuru
force-pushed
the
guru/viewer-1200-avatar-rotates
branch
from
2fb93f7 to
c5a009e
Compare
|
But may be retarget it to maint C? |
Sounds good. |
See #1200
This change applies
pitch()to a copy of themFrameAgentand checks the resulting vertical angleThe new value of
mFrameAgentis used only if the resulting vertical angle doesn't exceed the limitsThis method is more precise than any attempts to guess the resulting angle before applying
pitch()