#3403 fix Favorited worn outfit not coloured in My Outfits tab

Author: maxim-productengine

indra/newview/lloutfitslist.cpp

@@ -1606,39 +1606,32 @@ bool LLOutfitAccordionCtrlTab::handleToolTip(S32 x, S32 y, MASK mask)
 void LLOutfitAccordionCtrlTab::setFavorite(bool is_favorite)
 {
     mIsFavorite = is_favorite;
-    static LLUICachedControl<bool> highlight_color("InventoryFavoritesColorText", true);
-    if (!mIsSelected && mIsFavorite && highlight_color())
-    {
-        setTitleColor(LLUIColorTable::instance().getColor("InventoryFavoriteColor"));
-    }
-    else
-    {
-        setTitleColor(LLUIColorTable::instance().getColor("AccordionHeaderTextColor"));
-    }
+    updateTitleColor();
 }
 
 void LLOutfitAccordionCtrlTab::setOutfitSelected(bool val)
 {
     mIsSelected = val;
-    if (val)
-    {
-        setTitleFontStyle("BOLD");
-        setTitleColor(LLUIColorTable::instance().getColor("SelectedOutfitTextColor"));
+    setTitleFontStyle(mIsSelected ? "BOLD" : "NORMAL");
+    updateTitleColor();
     }
-    else
+
+void LLOutfitAccordionCtrlTab::updateTitleColor()
     {
-        setTitleFontStyle("NORMAL");
         static LLUICachedControl<bool> highlight_color("InventoryFavoritesColorText", true);
         if (mIsFavorite && highlight_color())
         {
             setTitleColor(LLUIColorTable::instance().getColor("InventoryFavoriteColor"));
         }
+    else if (mIsSelected)
+    {
+        setTitleColor(LLUIColorTable::instance().getColor("SelectedOutfitTextColor"));
+    }
         else
         {
             setTitleColor(LLUIColorTable::instance().getColor("AccordionHeaderTextColor"));
         }
     }
-}
 
 void LLOutfitAccordionCtrlTab::drawFavoriteIcon()
 {

indra/newview/lloutfitslist.h

@@ -276,6 +276,7 @@ class LLOutfitAccordionCtrlTab : public LLAccordionCtrlTab
     {}
     friend class LLUICtrlFactory;
 
+    void updateTitleColor();
     void drawFavoriteIcon();
 
     LLUUID mFolderID;
@@ -431,7 +432,7 @@ class LLOutfitsList : public LLOutfitListBase
     // Used to monitor COF changes for updating items worn state. See EXT-8636.
     uuid_vec_t                      mCOFLinkedItems;
 
-    LLOutfitListSortMenu*           mSortMenu;
+    LLOutfitListSortMenu*         mSortMenu;
 
     //bool                          mIsInitialized;
     /**