fix: scanny#758 quote in autoshape name must be escaped

At least one autoshape name ('"No" Symbol') contains the double-quote
character which raises an XML exception when it prematurely terminates
the `name="..."` attribute of the autoshape. Escape autoshape basename
to avoid this problem, specifically targetting the double-quote
character.

Author: scanny

pptx/enum/shapes.py

@@ -501,7 +501,7 @@ class MSO_AUTO_SHAPE_TYPE(XmlEnumeration):
             "notchedRightArrow",
             "Notched block arrow that points right",
         ),
-        XmlMappedEnumMember("NO_SYMBOL", 19, "noSmoking", '"No" symbol'),
+        XmlMappedEnumMember("NO_SYMBOL", 19, "noSmoking", '"No" Symbol'),
         XmlMappedEnumMember("OCTAGON", 6, "octagon", "Octagon"),
         XmlMappedEnumMember("OVAL", 9, "ellipse", "Oval"),
         XmlMappedEnumMember(
@@ -858,11 +858,7 @@ def width(self):
             return self._width
 
     def __contains__(self, item):
-        return item in (
-            self.DOCX,
-            self.PPTX,
-            self.XLSX,
-        )
+        return item in (self.DOCX, self.PPTX, self.XLSX,)
 
     def __repr__(self):
         return "%s.PROG_ID" % __name__

pptx/shapes/autoshape.py

@@ -5,6 +5,7 @@
 from __future__ import absolute_import, division, print_function, unicode_literals
 
 from numbers import Number
+import xml.sax.saxutils as saxutils
 
 from pptx.dml.fill import FillFormat
 from pptx.dml.line import LineFormat
@@ -234,11 +235,14 @@ def autoshape_type_id(self):
 
     @property
     def basename(self):
+        """Base of shape name for this auto shape type.
+
+        A shape name is like "Rounded Rectangle 7" and appears as an XML attribute for
+        example at `p:sp/p:nvSpPr/p:cNvPr{name}`. This basename value is the name less
+        the distinguishing integer. This value is escaped because at least one
+        autoshape-type name includes double quotes ('"No" Symbol').
         """
-        Base of shape name (less the distinguishing integer) for this auto
-        shape type
-        """
-        return self._basename
+        return saxutils.escape(self._basename, {'"': """})
 
     @classmethod
     def default_adjustment_values(cls, prst):

pptx/spec.py

@@ -468,7 +468,7 @@
         "basename": "Notched Right Arrow",
         "avLst": (("adj1", 50000), ("adj2", 50000)),
     },
-    MSO_SHAPE.NO_SYMBOL: {"basename": '"No" symbol', "avLst": (("adj", 18750),)},
+    MSO_SHAPE.NO_SYMBOL: {"basename": '"No" Symbol', "avLst": (("adj", 18750),)},
     MSO_SHAPE.OCTAGON: {"basename": "Octagon", "avLst": (("adj", 29289),)},
     MSO_SHAPE.OVAL: {"basename": "Oval", "avLst": ()},
     MSO_SHAPE.OVAL_CALLOUT: {

tests/shapes/test_autoshape.py

@@ -260,12 +260,20 @@ def indexed_assignment_fixture_(self, request):
 
 
 class DescribeAutoShapeType(object):
+    """Unit-test suite for `pptx.shapes.autoshape.AutoShapeType`"""
+
     def it_knows_the_details_of_the_auto_shape_type_it_represents(self):
         autoshape_type = AutoShapeType(MSO_SHAPE.ROUNDED_RECTANGLE)
         assert autoshape_type.autoshape_type_id == MSO_SHAPE.ROUNDED_RECTANGLE
         assert autoshape_type.prst == "roundRect"
         assert autoshape_type.basename == "Rounded Rectangle"
 
+    def it_xml_escapes_the_basename_when_the_name_contains_special_characters(self):
+        autoshape_type = AutoShapeType(MSO_SHAPE.NO_SYMBOL)
+        assert autoshape_type.autoshape_type_id == MSO_SHAPE.NO_SYMBOL
+        assert autoshape_type.prst == "noSmoking"
+        assert autoshape_type.basename == ""No" Symbol"
+
     def it_knows_the_default_adj_vals_for_its_autoshape_type(
         self, default_adj_vals_fixture_
     ):