Skip to content

Use new classifier format for packaging #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jun 9, 2025

  • update Scapy to new classifiers format (Python 3.13)
  • minor type fixes

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (cbb09c4) to head (55ae968).

Files with missing lines Patch % Lines
scapy/utils.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4768      +/-   ##
==========================================
- Coverage   81.26%   81.21%   -0.05%     
==========================================
  Files         363      345      -18     
  Lines       88325    88057     -268     
==========================================
- Hits        71773    71514     -259     
+ Misses      16552    16543       -9     
Files with missing lines Coverage Δ
scapy/config.py 80.52% <100.00%> (-0.03%) ⬇️
scapy/layers/l2.py 83.91% <ø> (-0.04%) ⬇️
scapy/layers/smbclient.py 70.91% <ø> (-0.04%) ⬇️
scapy/utils.py 74.16% <0.00%> (-0.28%) ⬇️

... and 274 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa
Copy link
Contributor

Thanks for the PR. LGTM

@gpotter2
Copy link
Member Author

It doesn't work on 3.7 and 3.8 though because a setuptools versions that goes as far doesn't exist :/ I need to think a bit about what to do

@gpotter2 gpotter2 marked this pull request as draft June 15, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants