-
-
Couldn't load subscription status.
- Fork 2.2k
Moved the metadata into setup.cfg.
#3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3664 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 296 296
Lines 62214 62267 +53
=======================================
+ Hits 52616 52663 +47
- Misses 9598 9604 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I like modern stuff so I quite like it. Regarding compatibility: onekey-sec/arpy#18 (comment) (we still support Python 2.7...)
Oops, forgot to add it. But given
Should I land the second commit converting |
|
We are currently looking towards releasing Scapy 2.5.0 which should be the last version to support Python 2.7 (at least I'd like so). |
|
OK. In the current state this PR should support 2.7. |
d5034d2 to
34f715e
Compare
|
LGTM |
34f715e to
07ae0b5
Compare
Added `pyproject.toml`
07ae0b5 to
71e1633
Compare
Added
pyproject.tomlChecklist:
toxor,cd test && ./run_tests_py2, cd test && ./run_tests_py3) - not neededMoves the metadata into the declarative config according to
PEP 621, which is more editable and readable with automatic tools and somewhen in future will allow to forbidsetup.pyas an unjustified potential security threat.