Skip to content

Fix threading related deprecations in Python 3.10. #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

Fix threading related deprecations in Python 3.10. #3244

merged 1 commit into from
Jun 13, 2021

Conversation

@tirkarthi
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests for Python2 and Python3 (using tox or, cd test && ./run_tests_py2, cd test && ./run_tests_py3)
  • If the PR is still not finished, please create a Draft Pull Request

Fixes #3243

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3244 (33016ea) into master (a33af34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3244   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         271      271           
  Lines       55364    55366    +2     
=======================================
+ Hits        47498    47504    +6     
+ Misses       7866     7862    -4
Impacted Files Coverage Δ
scapy/automaton.py 75.10% <100.00%> (ø)
scapy/pipetool.py 86.09% <100.00%> (ø)
scapy/sendrecv.py 84.84% <100.00%> (+1.00%) ⬆️
scapy/arch/windows/__init__.py 67.73% <0.00%> (-0.57%) ⬇️
scapy/layers/l2.py 76.17% <0.00%> (-0.24%) ⬇️
scapy/layers/inet.py 66.00% <0.00%> (+0.07%) ⬆️
scapy/sessions.py 95.42% <0.00%> (+0.57%) ⬆️

gpotter2
gpotter2 approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@gpotter2 gpotter2 merged commit a6bf8dd into secdev:master Jun 13, 2021
@gpotter2 gpotter2 added this to the 2.5.0 milestone Mar 29, 2022
gpotter2 added a commit that referenced this pull request Feb 17, 2023
@gpotter2 @KOLANICH
Migrate to pyproject.toml (#3869)
669506b 
* Migrate to `pyproject.toml`

Co-authored-by: KOLANICH <kolan_n@mail.ru>

* Bump setuptools to 62.0.0

Otherwise we suffer from the bug described in pypa/setuptools, #3244

* Codecov: xml upload

---------

Co-authored-by: KOLANICH <kolan_n@mail.ru>
muttiopenbts pushed a commit to muttiopenbts/scapy that referenced this pull request Feb 21, 2023
@gpotter2 @KOLANICH
Migrate to pyproject.toml (secdev#3869)
04e94fb 
* Migrate to `pyproject.toml`

Co-authored-by: KOLANICH <kolan_n@mail.ru>

* Bump setuptools to 62.0.0

Otherwise we suffer from the bug described in pypa/setuptools, secdev#3244

* Codecov: xml upload

---------

Co-authored-by: KOLANICH <kolan_n@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpotter2 gpotter2 gpotter2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Threading related deprecations in Python 3.10

2 participants

@tirkarthi @gpotter2