Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: src/arch-syscall-check.c should also verify the presence of the __SNR_xxx defines #315

Open
pcmoore opened this issue Feb 4, 2021 · 1 comment

Comments

@pcmoore
Copy link
Member

pcmoore commented Feb 4, 2021

This came out of issue #314. While arch-syscall-check.c is good at ensuring the internal libseccomp syscall tables are consistent across arch/ABIs, it doesn't verify that we have the necessary __SNR_xxx definitions to match.

@pcmoore
Copy link
Member Author

pcmoore commented Feb 4, 2021

It's worth noting that the move to the CSV syscall table means the current tests in src/arch-syscall-check.c are largely pointless; the automatically generated syscall tables should always be in sync across the different arch/ABIs. This isn't to see we need to drop these existing checks, but if dropping these checks makes it easier to solve this issue I have no problem doing that.

@pcmoore pcmoore modified the milestones: v2.6.0, v2.7.0 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant