Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of NamePrettifier::prettifyTestMethodName() #5748

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 13, 2024

the function call is showing up in blackfire profiles of blackfire run php ./phpunit --testsuite unit

grafik

diff

grafik

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (59ad5c9) to head (ada5966).

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #5748   +/-   ##
=========================================
  Coverage     90.08%   90.09%           
- Complexity     6437     6438    +1     
=========================================
  Files           680      680           
  Lines         19535    19536    +1     
=========================================
+ Hits          17599    17601    +2     
+ Misses         1936     1935    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory) labels Mar 14, 2024
@sebastianbergmann sebastianbergmann changed the title Faster NamePrettifier->prettifyTestMethodName() Improve performance of NamePrettifier::prettifyTestMethodName() Mar 14, 2024
@sebastianbergmann sebastianbergmann merged commit 75d9f12 into sebastianbergmann:10.5 Mar 14, 2024
31 checks passed
@staabm staabm deleted the micro-pretty branch March 14, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants