Use temporary file (instead of STDOUT) to communicate result from child process to parent process #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
feature/test-runner
Codecov Report
@@ Coverage Diff @@
## main #5290 +/- ##
============================================
+ Coverage 84.89% 84.92% +0.03%
+ Complexity 6110 6108 -2
============================================
Files 651 651
Lines 19355 19343 -12
============================================
- Hits 16431 16428 -3
+ Misses 2924 2915 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ld process to parent process
sebastianbergmann
force-pushed
the
do-not-use-stdout-to-communicate-result-from-child-process-to-parent-process
branch
from
da067ac
to
9ea7248
Compare
sebastianbergmann
deleted the
do-not-use-stdout-to-communicate-result-from-child-process-to-parent-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently worked with an application that used an unusual combination of output buffering, custom error handling, custom exception handling, and custom shutdown handling.
The way this application works got in the way of writing edge-to-edge characterization tests for the application: trying to run such a test in a separate PHP process (using PHPUnit's process isolation functionality) did not work.
The application's custom error handler acted on
E_DEPRECATEDevents emitted by the PHP interpreter for code generated by PHPUnit. This was taken care of in #5270.The application's use of output buffering interfered with the way that PHPUnit currently communicated results from a child process to the parent process.
These changes made PHPUnit's process isolation functionality work in the context of that application. They also do not break any existing test. However, they feel like a short-term solution for an edge case problem.
Considering other problems such as #5230, I would much rather completely rethink how process isolation should work.