Method assertSame doesn't create ComparisonFailure for arrays

[SvetlanaZem]

<?php
class CompareTest extends PHPUnit_Framework_TestCase
{
    public function testSame()
    {
        $this->assertSame(array('one'), array('two'));
    }

    public function testEquals()
    {
        $this->assertEquals(array('one'), array('two'));
    }
}

Method $this->assertSame(array('one'), array('two')); will throw PHPUnit_Framework_ExpectationFailedException with ComparisonFailure equals to null while method $this->assertEquals(...) will create proper ComparisonFailure object.

$this->assertSame(...) uses PHPUnit_Framework_Constraint_IsIdentical.evaluate(...)
$this->assertEquals(...) uses PHPUnit_Framework_Constraint_IsEqual.evaluate(...)

The issue was reproduced with PHPUnit 5.3

Corresponding PhpStorm issue: https://youtrack.jetbrains.com/issue/WI-31705

Would be great to see the array diff of assertEquals in assertSame calls (was requested earlier in #1252)

[mhujer]

Here is a better example to compare the behaviour of the assertEquals()/assertSame():

<?php declare(strict_types = 1);

use PHPUnit\Framework\TestCase;

class ArrayDiffTest extends TestCase
{

	public function testEquality()
	{
		$this->assertEquals(
			[1, 2, 3, 4, 5, 6],
			[1, 2, 33, 4, 5, 6]
		);
	}

	public function testSame()
	{
		$this->assertSame(
			[1, 2, 3, 4, 5, 6],
			[1, 2, 33, 4, 5, 6]
		);
	}
}

Output:

1) ArrayDiffTest::testEquality                           
Failed asserting that two arrays are equal.              
--- Expected                                             
+++ Actual                                               
@@ @@                                                    
 Array (                                                 
     0 => 1                                              
     1 => 2                                              
-    2 => 3                                              
+    2 => 33                                             
                                                         
                                                         
2) ArrayDiffTest::testSame                               
Failed asserting that Array &0 (                         
    0 => 1                                               
    1 => 2                                               
    2 => 33                                              
    3 => 4                                               
    4 => 5                                               
    5 => 6                                               
) is identical to Array &0 (                             
    0 => 1                                               
    1 => 2                                               
    2 => 3                                               
    3 => 4                                               
    4 => 5                                               
    5 => 6                                               
).