Skip to content

Commit 9cd210a

Browse files
epdenoudensebastianbergmann
authored andcommitted
Protect JUnit logger against implementations without usesDataProvider()
1 parent f8a7421 commit 9cd210a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/Util/Log/JUnit.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,11 +290,17 @@ public function endTestSuite(TestSuite $suite): void
290290
*/
291291
public function startTest(Test $test): void
292292
{
293+
$usesDataprovider = false;
294+
295+
if (\method_exists($test, 'usesDataProvider')) {
296+
$usesDataprovider = $test->usesDataProvider();
297+
}
298+
293299
$testCase = $this->document->createElement('testcase');
294300
$testCase->setAttribute('name', $test->getName());
295301

296302
$class = new ReflectionClass($test);
297-
$methodName = $test->getName(!$test->usesDataProvider());
303+
$methodName = $test->getName(!$usesDataprovider);
298304

299305
if ($class->hasMethod($methodName)) {
300306
$method = $class->getMethod($methodName);

0 commit comments

Comments
 (0)