Avoid duplicate list elements

Author: sebastianbergmann

src/Logging/TestDox/HtmlRenderer.php

@@ -115,11 +115,11 @@ public function render(array $tests): string
                 $prettifiedClassName
             );
 
-            foreach ($_tests as $test) {
+            foreach ($this->reduce($_tests) as $prettifiedMethodName => $outcome) {
                 $buffer .= sprintf(
                     "            <li class=\"%s\">%s</li>\n",
-                    $test->status()->isSuccess() ? 'success' : 'defect',
-                    $test->test()->testDox()->prettifiedMethodName()
+                    $outcome,
+                    $prettifiedMethodName
                 );
             }
 
@@ -128,4 +128,30 @@ public function render(array $tests): string
 
         return $buffer . self::PAGE_FOOTER;
     }
+
+    /**
+     * @psalm-return array<string, 'success'|'defect'>
+     */
+    private function reduce(TestResultCollection $tests): array
+    {
+        $result = [];
+
+        foreach ($tests as $test) {
+            $prettifiedMethodName = $test->test()->testDox()->prettifiedMethodName();
+
+            if (!isset($result[$prettifiedMethodName])) {
+                $result[$prettifiedMethodName] = $test->status()->isSuccess() ? 'success' : 'defect';
+
+                continue;
+            }
+
+            if ($test->status()->isSuccess()) {
+                continue;
+            }
+
+            $result[$prettifiedMethodName] = 'defect';
+        }
+
+        return $result;
+    }
 }

src/Logging/TestDox/PlainTextRenderer.php

@@ -26,11 +26,11 @@ public function render(array $tests): string
         foreach ($tests as $prettifiedClassName => $_tests) {
             $buffer .= $prettifiedClassName . "\n";
 
-            foreach ($_tests as $test) {
+            foreach ($this->reduce($_tests) as $prettifiedMethodName => $outcome) {
                 $buffer .= sprintf(
                     ' [%s] %s' . "\n",
-                    $test->status()->isSuccess() ? 'x' : ' ',
-                    $test->test()->testDox()->prettifiedMethodName()
+                    $outcome,
+                    $prettifiedMethodName
                 );
             }
 
@@ -39,4 +39,30 @@ public function render(array $tests): string
 
         return $buffer;
     }
+
+    /**
+     * @psalm-return array<string, 'x'|' '>
+     */
+    private function reduce(TestResultCollection $tests): array
+    {
+        $result = [];
+
+        foreach ($tests as $test) {
+            $prettifiedMethodName = $test->test()->testDox()->prettifiedMethodName();
+
+            if (!isset($result[$prettifiedMethodName])) {
+                $result[$prettifiedMethodName] = $test->status()->isSuccess() ? 'x' : ' ';
+
+                continue;
+            }
+
+            if ($test->status()->isSuccess()) {
+                continue;
+            }
+
+            $result[$prettifiedMethodName] = ' ';
+        }
+
+        return $result;
+    }
 }

tests/end-to-end/logging/testdox-html.phpt

@@ -77,7 +77,6 @@ unlink($output);
         <ul>
             <li class="success">Balance is initially zero</li>
             <li class="success">Balance cannot become negative</li>
-            <li class="success">Balance cannot become negative</li>
         </ul>
     </body>
 </html>

tests/end-to-end/logging/testdox-text.phpt

@@ -22,4 +22,3 @@ unlink($output);
 Bank Account (PHPUnit\TestFixture\BankAccount)
  [x] Balance is initially zero
  [x] Balance cannot become negative
- [x] Balance cannot become negative