Cache result of prettifyTestCase()

Author: sebastianbergmann

src/Logging/TestDox/NamePrettifier.php

@@ -59,6 +59,11 @@ final class NamePrettifier
      */
     private array $strings = [];
 
+    /**
+     * @var array<non-empty-string, non-empty-string>
+     */
+    private array $prettifiedTestCases = [];
+
     /**
      * @param class-string $className
      */
@@ -172,40 +177,39 @@ public function prettifyTestMethodName(string $name): string
 
     public function prettifyTestCase(TestCase $test, bool $colorize): string
     {
-        $annotationWithPlaceholders = false;
-        $methodLevelTestDox         = MetadataRegistry::parser()->forMethod($test::class, $test->name())->isTestDox()->isMethodLevel();
+        $key = $test::class . '#' . $test->name();
 
-        if ($methodLevelTestDox->isNotEmpty()) {
-            $methodLevelTestDox = $methodLevelTestDox->asArray()[0];
+        if ($test->usesDataProvider()) {
+            $key .= '#' . $test->dataName();
+        }
 
-            assert($methodLevelTestDox instanceof TestDox);
+        if ($colorize) {
+            $key .= '#colorize';
+        }
 
-            $result = $methodLevelTestDox->text();
+        if (isset($this->prettifiedTestCases[$key])) {
+            return $this->prettifiedTestCases[$key];
+        }
 
-            if (str_contains($result, '$')) {
-                $annotation   = $result;
-                $providedData = $this->mapTestMethodParameterNamesToProvidedDataValues($test, $colorize);
+        $testDox      = MetadataRegistry::parser()->forMethod($test::class, $test->name())->isTestDox()->isMethodLevel();
+        $isCustomized = false;
 
-                $variables = array_map(
-                    static fn (string $variable): string => sprintf(
-                        '/%s(?=\b)/',
-                        preg_quote($variable, '/'),
-                    ),
-                    array_keys($providedData),
-                );
+        if ($testDox->isNotEmpty()) {
+            $testDox = $testDox->asArray()[0];
 
-                $result = preg_replace($variables, $providedData, $annotation);
+            assert($testDox instanceof TestDox);
 
-                $annotationWithPlaceholders = true;
-            }
+            [$result, $isCustomized] = $this->processTestDox($test, $testDox, $colorize);
         } else {
             $result = $this->prettifyTestMethodName($test->name());
         }
 
-        if (!$annotationWithPlaceholders && $test->usesDataProvider()) {
+        if (!$isCustomized && $test->usesDataProvider()) {
             $result .= $this->prettifyDataSet($test, $colorize);
         }
 
+        $this->prettifiedTestCases[$key] = $result;
+
         return $result;
     }
 
@@ -305,4 +309,33 @@ private function objectToString(object $value): string
 
         return $value::class;
     }
+
+    /**
+     * @return array{0: string, 1: bool}
+     */
+    private function processTestDox(TestCase $test, TestDox $testDox, bool $colorize): array
+    {
+        $placeholdersUsed = false;
+
+        $result = $testDox->text();
+
+        if (str_contains($result, '$')) {
+            $annotation   = $result;
+            $providedData = $this->mapTestMethodParameterNamesToProvidedDataValues($test, $colorize);
+
+            $variables = array_map(
+                static fn (string $variable): string => sprintf(
+                    '/%s(?=\b)/',
+                    preg_quote($variable, '/'),
+                ),
+                array_keys($providedData),
+            );
+
+            $result = preg_replace($variables, $providedData, $annotation);
+
+            $placeholdersUsed = true;
+        }
+
+        return [$result, $placeholdersUsed];
+    }
 }