Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to remove if expressions #221

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Oct 20, 2024

Closes #208 Closes #207

This PR add a new rule that remove if expressions and convert them into an equivalent expression.

  • add entry to the changelog
  • update docs

Copy link

Coverage after merging remove-if-expression into main will be

87.02%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/process/evaluator
   mod.rs87.74%100%98.18%86.49%102–103, 164, 176, 187, 198, 207–209, 215–217, 219–221, 223–224, 227, 239–241, 253–257, 261–262, 264–266, 306, 327, 341, 365, 368, 401, 407–408, 413, 427, 430, 448, 551, 58–60, 71, 812, 88–89
src/rules
   mod.rs89.03%100%82.86%89.79%114–116, 130–132, 150–152, 154, 185–187, 282, 322–324, 351, 358–361, 375, 424–426
   remove_if_expression.rs100%100%100%100%

@jeparlefrancais jeparlefrancais merged commit 1752449 into main Oct 21, 2024
6 checks passed
@jeparlefrancais jeparlefrancais deleted the remove-if-expression branch October 21, 2024 02:20
jackTabsCode pushed a commit to jackTabsCode/darklua that referenced this pull request Oct 27, 2024
This PR add a new rule that remove `if` expressions and convert them
into an equivalent expression.

---------

Co-authored-by: jiwonz <jiwonz0113@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove if expressions
2 participants