Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix key to fetch html with namespace #3

Merged
merged 1 commit into from
Dec 13, 2015
Merged

Prefix key to fetch html with namespace #3

merged 1 commit into from
Dec 13, 2015

Conversation

kategengler
Copy link
Contributor

Fixes #2

- The value of the ":current" key put there by ember-cli-deploy is the
  revision, not the redis key
@@ -52,7 +52,8 @@ def current_key
end

def deploy_key
redis_client.get(current_key).presence || deployment_not_activated!
key = redis_client.get(current_key).presence || deployment_not_activated!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

@seanpdoyle
Copy link
Owner

Hey @kategengler, thanks for opening this issue and bringing this to our attention.

Do you use this gem on its own, or are you also using ember-cli-rails?

I ask because we recently opened a PR (#4) to integrate more deeply with ember-cli-rails.

That PR incorporates these changes, but comes with lots of breaking changes. To continue to use this gem in its current form, you'd have to reimplement the Page class.

I'll merge this PR as part of an 0.0.2 release, but it is likely there will be breaking changes coming in an 0.1.0 version. I just wanted to give you a heads up and get some user feedback.

If you haven't used ember-cli-rails in the past (or if you have and had a negative experience), we've just released 0.6.0 which resolves all the issues we've had in the past.

Please try it out: https://github.com/thoughtbot/ember-cli-rails

@seanpdoyle seanpdoyle merged commit 7b22227 into seanpdoyle:master Dec 13, 2015
@seanpdoyle
Copy link
Owner

@kategengler
Copy link
Contributor Author

Hi @seanpdoyle - The project I used this gem for had actually been on ember-cli-rails and moved off of it because they wanted the application in a separate repo and to deploy it on different schedule from the Rails app. This gem nicely worked great as a counterpart to ember-cli-deploy-lightning-pack for handling everything Rails side and making use of append_to_head. On previous projects, I implemented those features myself and could easily go back to doing that or maintain a fork If this gem is going to be intended to be used with ember-cli-rails only.

@seanpdoyle
Copy link
Owner

@kategengler I've extracted the html_page gem from ember-cli-rails.

I've also added a section to the #4 README.md explaining how to achieve the behavior you're describing without ember-cli-rails.

Would you mind providing feedback on #4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants