Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm::multipart: missing fn headers() #2035

Closed
bitfl0wer opened this issue Nov 13, 2023 · 2 comments · Fixed by #2036
Closed

wasm::multipart: missing fn headers() #2035

bitfl0wer opened this issue Nov 13, 2023 · 2 comments · Fixed by #2036

Comments

@bitfl0wer
Copy link
Contributor

Currently (v0.11.22), compiling for --target=wasm32-unknown-unknown leads to a missing fn headers() for setting the headers of a multipart form. It seems to me, that the wasm implementation is simply missing the method fn headers in impl Part and impl PartMetadata respectively. I have forked the repository, added the two missing methods into a branch based on tag 0.11.2, and reqwest compiles just fine for the wasm target. I haven't been able to test the method yet though.

Was it intended for these functions to be missing for wasm?

@seanmonstar
Copy link
Owner

If a method is missing, and adding it doesn't require adding a new dependency or exposing something unique to WASM, then we likely just forgot about it.

@bitfl0wer
Copy link
Contributor Author

Thanks for the quick reply!

I have opened a PR which hopefully resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants