Validate custom commands in sub menus

Author: stefanhaller

pkg/config/user_config_validation.go

@@ -101,21 +101,26 @@ func validateCustomCommands(customCommands []CustomCommand) error {
 			return err
 		}
 
-		if len(customCommand.CommandMenu) > 0 &&
-			(len(customCommand.Context) > 0 ||
+		if len(customCommand.CommandMenu) > 0 {
+			if len(customCommand.Context) > 0 ||
 				len(customCommand.Command) > 0 ||
 				customCommand.Subprocess != nil ||
 				len(customCommand.Prompts) > 0 ||
 				len(customCommand.LoadingText) > 0 ||
 				customCommand.Stream != nil ||
 				customCommand.ShowOutput != nil ||
 				len(customCommand.OutputTitle) > 0 ||
-				customCommand.After != nil) {
-			commandRef := ""
-			if len(customCommand.Key) > 0 {
-				commandRef = fmt.Sprintf(" with key '%s'", customCommand.Key)
+				customCommand.After != nil {
+				commandRef := ""
+				if len(customCommand.Key) > 0 {
+					commandRef = fmt.Sprintf(" with key '%s'", customCommand.Key)
+				}
+				return fmt.Errorf("Error with custom command%s: it is not allowed to use both commandMenu and any of the other fields except key and description.", commandRef)
+			}
+
+			if err := validateCustomCommands(customCommand.CommandMenu); err != nil {
+				return err
 			}
-			return fmt.Errorf("Error with custom command%s: it is not allowed to use both commandMenu and any of the other fields except key and description.", commandRef)
 		}
 	}
 	return nil

pkg/config/user_config_validation_test.go

@@ -92,10 +92,7 @@ func TestUserConfigValidate_enums(t *testing.T) {
 				{value: "<disabled>", valid: true},
 				{value: "q", valid: true},
 				{value: "<c-c>", valid: true},
-				/* EXPECTED:
 				{value: "invalid_value", valid: false},
-				ACTUAL */
-				{value: "invalid_value", valid: true},
 			},
 		},
 		{