Skip to content

Commit 19942d4

Browse files
committed
KVM: selftests: Verify that faulting in private guest_memfd memory fails
Add a guest_memfd testcase to verify that faulting in private memory gets a SIGBUS. For now, test only the case where memory is private by default since KVM doesn't yet support in-place conversion. Deliberately run the CoW test with and without INIT_SHARED set as KVM should disallow MAP_PRIVATE regardless of whether the memory itself is private from a CoCo perspective. Cc: Ackerley Tng <ackerleytng@google.com> Reviewed-by: Fuad Tabba <tabba@google.com> Tested-by: Fuad Tabba <tabba@google.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Ackerley Tng <ackerleytng@google.com> Tested-by: Ackerley Tng <ackerleytng@google.com> Link: https://lore.kernel.org/r/20251003232606.4070510-13-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent f91187c commit 19942d4

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

tools/testing/selftests/kvm/guest_memfd_test.c

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,8 @@ static void test_mmap_supported(int fd, size_t total_size)
7575
kvm_munmap(mem, total_size);
7676
}
7777

78-
static void test_fault_overflow(int fd, size_t total_size)
78+
static void test_fault_sigbus(int fd, size_t accessible_size, size_t map_size)
7979
{
80-
size_t map_size = total_size * 4;
8180
const char val = 0xaa;
8281
char *mem;
8382
size_t i;
@@ -86,12 +85,22 @@ static void test_fault_overflow(int fd, size_t total_size)
8685

8786
TEST_EXPECT_SIGBUS(memset(mem, val, map_size));
8887

89-
for (i = 0; i < total_size; i++)
88+
for (i = 0; i < accessible_size; i++)
9089
TEST_ASSERT_EQ(READ_ONCE(mem[i]), val);
9190

9291
kvm_munmap(mem, map_size);
9392
}
9493

94+
static void test_fault_overflow(int fd, size_t total_size)
95+
{
96+
test_fault_sigbus(fd, total_size, total_size * 4);
97+
}
98+
99+
static void test_fault_private(int fd, size_t total_size)
100+
{
101+
test_fault_sigbus(fd, 0, total_size);
102+
}
103+
95104
static void test_mmap_not_supported(int fd, size_t total_size)
96105
{
97106
char *mem;
@@ -260,9 +269,14 @@ static void __test_guest_memfd(struct kvm_vm *vm, uint64_t flags)
260269
gmem_test(file_read_write, vm, flags);
261270

262271
if (flags & GUEST_MEMFD_FLAG_MMAP) {
263-
gmem_test(mmap_supported, vm, flags);
272+
if (flags & GUEST_MEMFD_FLAG_INIT_SHARED) {
273+
gmem_test(mmap_supported, vm, flags);
274+
gmem_test(fault_overflow, vm, flags);
275+
} else {
276+
gmem_test(fault_private, vm, flags);
277+
}
278+
264279
gmem_test(mmap_cow, vm, flags);
265-
gmem_test(fault_overflow, vm, flags);
266280
} else {
267281
gmem_test(mmap_not_supported, vm, flags);
268282
}
@@ -282,6 +296,8 @@ static void test_guest_memfd(unsigned long vm_type)
282296
__test_guest_memfd(vm, 0);
283297

284298
flags = vm_check_cap(vm, KVM_CAP_GUEST_MEMFD_FLAGS);
299+
if (flags & GUEST_MEMFD_FLAG_MMAP)
300+
__test_guest_memfd(vm, GUEST_MEMFD_FLAG_MMAP);
285301

286302
/* MMAP should always be supported if INIT_SHARED is supported. */
287303
if (flags & GUEST_MEMFD_FLAG_INIT_SHARED)

0 commit comments

Comments
 (0)