You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The metadata's detect_from_dataframes is currently meant to be used on a pre-existing instance of a metadata object. The function internally updates the metadata object and doesn't return anything.
The usage leads to some redundant code and confusion because you have to instantiate the object separately (why?), and it's unexpected that detection would not return anything. Additionally, we only expect this function to be used once, so it's not clear why it's possible to apply it to the same object multiple times.
Expected behavior
To improve the usage of this function, we will make it a class function that ultimately returns an instance of the metadata object.
Problem Description
The metadata's
detect_from_dataframes
is currently meant to be used on a pre-existing instance of a metadata object. The function internally updates the metadata object and doesn't return anything.The usage leads to some redundant code and confusion because you have to instantiate the object separately (why?), and it's unexpected that detection would not return anything. Additionally, we only expect this function to be used once, so it's not clear why it's possible to apply it to the same object multiple times.
Expected behavior
To improve the usage of this function, we will make it a class function that ultimately returns an instance of the metadata object.
Additional context
All detection functions will be updated to follow this paradigm. See:
detect_from_dataframe
(singular) improvements, specified in Add a Metadata.detect_from_dataframe function #2211detect_from_ddl
improvements specified in Add a Metadata.detect_from_ddl function #2212The text was updated successfully, but these errors were encountered: