Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtypes] Update the NumericalFormatter to use the learn_rounding_digits from RDT #2164

Closed
R-Palazzo opened this issue Aug 2, 2024 · 0 comments · Fixed by #2165
Closed

[dtypes] Update the NumericalFormatter to use the learn_rounding_digits from RDT #2164

R-Palazzo opened this issue Aug 2, 2024 · 0 comments · Fixed by #2165
Assignees
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

Like other RDT transformers, the NumericalFormatter has to learn the rounding digits of the column it is transforming. Every RDT transformer that does this uses the utility method learn_rounding_digits.

Expected behavior

Remove this method:

def _learn_rounding_digits(data):

Replace its call by calling learn_rounding_digits from RDT

Additional context

After this change and when Issue 2156, RDT Issue 858, RDT Issue 855 are closed, sampling should work on SDV with the new pandas dtype on every python version.

@R-Palazzo R-Palazzo added feature request Request for a new feature new Automatic label applied to new issues labels Aug 2, 2024
@R-Palazzo R-Palazzo added this to the 1.15.1 milestone Aug 2, 2024
@R-Palazzo R-Palazzo self-assigned this Aug 2, 2024
@R-Palazzo R-Palazzo added maintenance Tasks related to infrastructure & dependencies and removed feature request Request for a new feature new Automatic label applied to new issues labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant