Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi table synthesizers to use new Metadata #2129

Closed
amontanez24 opened this issue Jul 15, 2024 · 2 comments · Fixed by #2146 or #2186
Closed

Enable multi table synthesizers to use new Metadata #2129

amontanez24 opened this issue Jul 15, 2024 · 2 comments · Fixed by #2146 or #2186
Assignees
Labels
feature:metadata Related to describing the dataset feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Jul 15, 2024

Problem Description

As a user, I'd like to be able to use my metadata wherever it is applicable once created without having to do extra work.

Expected behavior

Once #2104 is complete, we need to enable multi table synthesizers to work with the new Metadata

  • Support the new class on initialization
  • Deprecate MultiTableMetadata
    • Raise a future warning if users use this
  • They should be backwards compatible (still support the old class)

Additional context

Since the new class will be almost identical to the current MultiTableMetadata class, this should be a straightforward fix.

@amontanez24 amontanez24 added feature request Request for a new feature feature:metadata Related to describing the dataset labels Jul 15, 2024
@amontanez24 amontanez24 changed the title Enable single table synthesizers to use new Metadata Enable multi table synthesizers to use new Metadata Jul 15, 2024
@gsheni gsheni linked a pull request Aug 1, 2024 that will close this issue
@gsheni
Copy link
Contributor

gsheni commented Aug 1, 2024

Completed:
#2146

@amontanez24
Copy link
Contributor Author

This will be closed when #2186 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:metadata Related to describing the dataset feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants