Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find nested Faker provider submodules #630

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

frances-h
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2cf50ba) 100.00% compared to head (55d622a) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1572      1573    +1     
=========================================
+ Hits          1572      1573    +1     
Impacted Files Coverage Δ
rdt/transformers/pii/anonymizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frances-h frances-h marked this pull request as ready for review April 4, 2023 20:11
@frances-h frances-h requested a review from a team as a code owner April 4, 2023 20:11
@frances-h frances-h requested review from fealho, amontanez24 and pvk-developer and removed request for a team and fealho April 4, 2023 20:11
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit 5e577fb into master Apr 5, 2023
@frances-h frances-h deleted the issue-1346-sdv-faker-issue branch April 5, 2023 18:26
@amontanez24 amontanez24 added this to the 1.4.0 milestone Apr 12, 2023
@amontanez24 amontanez24 added the bug Something isn't working label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain sdtypes cause Faker to raise error
4 participants