Skip to content

Make OneHotEncoder dummies include NaN category #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

sarahmish
Copy link
Contributor

Make variables private and change dummies to include nan.
Resolve #208

@sarahmish sarahmish requested a review from csala August 12, 2021 20:41
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @sarahmish !

@csala csala requested a review from a team August 13, 2021 10:30
@sarahmish sarahmish merged commit 0eb8e6d into master Aug 13, 2021
@sarahmish sarahmish deleted the issue-208-ohe branch August 13, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneHotEncoder causing shape misalignment in CopulaGAN, CTGAN, and TVAE
3 participants