Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_faker_function from rdt/transformers/pii/utils.py #853

Closed
R-Palazzo opened this issue Jul 29, 2024 · 0 comments · Fixed by #854
Closed

Remove is_faker_function from rdt/transformers/pii/utils.py #853

R-Palazzo opened this issue Jul 29, 2024 · 0 comments · Fixed by #854
Assignees
@R-Palazzo
Labels
internal The issue doesn't change the API or functionality
Milestone
1.12.3

Comments

@R-Palazzo
Copy link
Contributor

R-Palazzo commented Jul 29, 2024 •
edited
Loading

Problem Description

The method is_faker_function that checks if an sdtype is a valid faker function is defined in rdt/transformers/pii/utils.py and also in rdt/transformers/pii/anonymization.py.
SDV uses the method defined in anonymization.py

Expected behavior

We should remove is_faker_function defined in rdt/transformers/pii/utils.py
@R-Palazzo R-Palazzo added the feature request Request for a new feature label Jul 29, 2024
@R-Palazzo R-Palazzo added this to the 1.12.3 milestone Jul 29, 2024
@R-Palazzo R-Palazzo self-assigned this Jul 29, 2024
@R-Palazzo R-Palazzo mentioned this issue Jul 29, 2024
Merged
@R-Palazzo R-Palazzo changed the title Improve time performance of is_faker_function Remove is_faker_function from rdt/transformers/pii/utils.py Jul 31, 2024
@amontanez24 amontanez24 added internal The issue doesn't change the API or functionality and removed feature request Request for a new feature labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-Palazzo R-Palazzo

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
1.12.3
Development

Successfully merging a pull request may close this issue.

Remove is_faker_function from rdt/transformers/pii/utils.py sdv-dev/RDT
2 participants
@amontanez24 @R-Palazzo