Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas FutureWarnings are disrupting tqdm progress bars #793

Closed
srinify opened this issue Apr 11, 2024 · 0 comments · Fixed by #805
Closed

Pandas FutureWarnings are disrupting tqdm progress bars #793

srinify opened this issue Apr 11, 2024 · 0 comments · Fixed by #805
Assignees
Labels
bug Something isn't working internal The issue doesn't change the API or functionality
Milestone

Comments

@srinify
Copy link

srinify commented Apr 11, 2024

Environment Details

When calling some functions in SDV like synthesizer.sample_remaining_columns(), the tqdm progress bar doesn't progress in-line. Instead, each update to the progress bar results in the display of a FutureWarning from pandas around the soon-to-be-deprecated fillna() function.

Untitled.mov
  • RDT version: 1.11.0

Proposed Solution

After a quick discussion with Neha, we should update the code to move away from these functions (not just suppress the warnings). We only use this function in a few places (4) in the RDT codebase:

https://github.com/search?q=repo%3Asdv-dev%2FRDT%20fillna&type=code

@srinify srinify added bug Something isn't working internal The issue doesn't change the API or functionality labels Apr 11, 2024
@amontanez24 amontanez24 added this to the 1.12.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants