Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-on detection for premium transformers #646

Closed
amontanez24 opened this issue May 16, 2023 · 0 comments · Fixed by #647
Closed

Add add-on detection for premium transformers #646

amontanez24 opened this issue May 16, 2023 · 0 comments · Fixed by #647
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented May 16, 2023

Problem Description

As a user, it would be useful to be able to import enterprise transformers in the same way I import public ones.

Expected behavior

  • Add add-on detection for transformers. There will be two types we need to support:
    1. Transformers to be added to already existing modules. An example of this is when we want to add premium transformers to the numerical module so that a user can do
    from rdt.transformers.numerical import PremiumNumericalTransformer
    1. Transformers in an entirely new module. An example could be if we wanted to add email transformers so a user could do
    from rdt.transformers.email import PremiumEmailTransformer

Additional context

  • When creating new transformer add-ons, the entrypoint group name we use should indicate which case it falls under. A proposal could be to do something like rdt.new_transformers_module vs rdt.existing_transformers_module. In the former case we would have to add the module to rdt.transformers and in the latter case we would have to add all the new module in the add on to the existing sdtype transformer module (ie. rdt.numerical)
  • We can use something similar to the add-on logic here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants