Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serialization of univariate distributions #99

Closed
ManuelAlvarezC opened this issue Aug 12, 2019 · 0 comments · Fixed by #100
Closed

Improve serialization of univariate distributions #99

ManuelAlvarezC opened this issue Aug 12, 2019 · 0 comments · Fixed by #100
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@ManuelAlvarezC
Copy link
Contributor

The current implementation of the to_dict and form_dict methods exposes the internal attribute constant_value and returns different values depending on its value.

We should change the implementation to make that all fitted distributions of the same class have the exact same serialization independently of the value of the constant_value attribute, and also have the attribute constant_value implicitly codified in the serialization.

@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Aug 12, 2019
@ManuelAlvarezC ManuelAlvarezC self-assigned this Aug 12, 2019
@csala csala added this to the 0.2.3 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants