Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to torch 2.0 #280

Closed
amontanez24 opened this issue Apr 20, 2023 · 0 comments · Fixed by #283 or #291
Closed

Upgrade to torch 2.0 #280

amontanez24 opened this issue Apr 20, 2023 · 0 comments · Fixed by #283 or #291
Assignees
@frances-h
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone
0.7.3

Comments

@amontanez24
Copy link
Contributor

Pytorch 2.0 was released a few weeks ago and is included as the default for Google Colab notebooks now.

Ideal Result: If CTGAN works on torch 2.0 (or if we can make minor modifications for it to work), then we should consider uncapping the max version of torch

Alternatively, we can just increase the cap for now to include 2.0.
@amontanez24 amontanez24 added the maintenance Tasks related to infrastructure & dependencies label Apr 20, 2023
@frances-h frances-h mentioned this issue Apr 26, 2023
Merged
@amontanez24 amontanez24 added this to the 0.7.2 milestone May 3, 2023
@amontanez24 amontanez24 removed this from the 0.7.2 milestone May 9, 2023
@amontanez24 amontanez24 reopened this May 9, 2023
@amontanez24 amontanez24 mentioned this issue May 11, 2023
Merged
@amontanez24 amontanez24 added this to the 0.7.3 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frances-h frances-h

Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
0.7.3
Development

Successfully merging a pull request may close this issue.

Unpin Torch requirement sdv-dev/CTGAN
Fixing: Torch 2.0 fails with cuda=False sdv-dev/CTGAN
2 participants
@amontanez24 @frances-h