You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if checking if a Slim file has valid Slim syntax would make sense as part of this linting tool. WDYT @sds ?
I just ran into an issue with a file with markup like this, which "passes" slim-lint but is not valid Slim:
' Hello. This is some simple math:
= 1 + 1 # this equals 2
The trailing Ruby style comment is actually not valid, and I always forget that.
The slim-lint check passed in our CI build, and we didn't happen to have a feature or view test for this file, so something like this got into our master branch. 😬
I wonder if checking if a Slim file has valid Slim syntax would make sense as part of this linting tool. WDYT @sds ?
I just ran into an issue with a file with markup like this, which "passes" slim-lint but is not valid Slim:
' Hello. This is some simple math: = 1 + 1 # this equals 2
The trailing Ruby style comment is actually not valid, and I always forget that.
The
slim-lint
check passed in our CI build, and we didn't happen to have a feature or view test for this file, so something like this got into ourmaster
branch. 😬Would it make sense for
slim-lint
to run theslimrb
command from the slim gem and fail the linting process if the file is not valid Slim?The text was updated successfully, but these errors were encountered: