Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default post-install hook #9

Open
jayvdb opened this issue May 26, 2021 · 1 comment
Open

Default post-install hook #9

jayvdb opened this issue May 26, 2021 · 1 comment

Comments

@jayvdb
Copy link

jayvdb commented May 26, 2021

When I install kscript via sdkman on Windows, I can invoke kscript after I do source "$HOME/.sdkman/bin/sdkman-init.sh"

When using this action, a .zip is dropped into the current directory, and nothing more is done.
https://api.sdkman.io/2/hooks/post/kscript/3.1.0/linux and https://api.sdkman.io/2/hooks/post/kscript/3.1.0/windows have no post-install hook.

I didnt see anything in https://github.com/search?q=org%3Asdkman+kscript&type=code which defines kscript, so I am at a bit of a loss for how sdkman knows how to handle each candidate.

I am guessing the real sdkman has some voodoo which unzips, recognises the bin/ inside, and makes the .jar executable.

It would be great if this github action could replicate the sdk commands post-install voodoo.

Alternatively, could this github action install the sdk cli.

@eddumelendez
Copy link
Member

Hi @jayvdb

Thanks for the report, it was an initial experimentation on this action. I am working on #11 which is actually using sdkman but is not running on windows. I just started this today so maybe a little bit more of research on my side to make it available on all OS. Also, look that for java I need actions/setup-java, I think with this new approach you will be able to run sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants