We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The url parameter is being decoded an extra time, meaning that normalization of bad urls is not possible in a straightforward way.
The offending second decode is lib/image-magick.js line 202, which causes it to fail on urls like
lib/image-magick.js line 202
http://localhost:3000/resize/magic?size=100x100&url=http%3A%2F%2Fthegenericman.com%2Fassets%2Fimg%2Fproduct_images%2Ftgm%2520large%2FGNRCMAN_122211-739.jpg
due to cURL's lack of normalization on its end (see #9).
Using params.url directly instead of decoding it (it's already been decoded at this point) resolves the issue.
params.url
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The url parameter is being decoded an extra time, meaning that normalization of bad urls is not possible in a straightforward way.
The offending second decode is
lib/image-magick.js line 202
, which causes it to fail on urls likedue to cURL's lack of normalization on its end (see #9).
Using
params.url
directly instead of decoding it (it's already been decoded at this point) resolves the issue.The text was updated successfully, but these errors were encountered: