Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH action to work with new minikube 1.22.0 #681

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fix GH action to work with new minikube 1.22.0 #681

merged 1 commit into from
Jul 8, 2021

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Jul 8, 2021 •
edited
Loading

Description of your changes:
Minikube kubernetes/minikube#11576 broke our install script, this PR reacts to the change and renames the config value.

This is currently blocking all CI.

# minikube config set embed-certs true

❌  Exiting due to MK_CONFIG_SET: find settings for "embed-certs" value of "true": property name "embed-certs" not found

@tnozicka tnozicka added this to the v1.4 milestone Jul 8, 2021
@tnozicka tnozicka added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 8, 2021
@tnozicka tnozicka requested a review from zimnx July 8, 2021 06:56
zimnx
zimnx approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@zimnx zimnx enabled auto-merge July 8, 2021 07:34
@tnozicka tnozicka disabled auto-merge July 8, 2021 11:24
@tnozicka tnozicka merged commit 5abf259 into scylladb:master Jul 8, 2021
@tnozicka tnozicka deleted the fix-minikube-install branch July 8, 2021 11:28
@rzetelskik rzetelskik mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees
No one assigned
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnozicka @zimnx