Skip to content

Commit 40a12fa

Browse files
committed
skip blocking on rolling restarts
1 parent e0ed02a commit 40a12fa

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/cmd/operator/bootstrapgate.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,17 @@ func (o *BootstrapGateOptions) Execute(ctx context.Context, originalStreams gene
209209
var err error
210210
ignoredNodes := apimachineryutilsets.New[string]()
211211

212-
// Rolling restart case.
212+
// FIXME
213+
// Skip the rolling restart case for now.
213214
if o.bootstrapped {
214215
if o.hostID == nil {
215216
return fmt.Errorf("node is bootstrapped but hostID is nil, this should never happen")
216217
}
217218

218219
// Node is restarting, other nodes are going to consider it down.
219-
ignoredNodes.Insert(*o.hostID)
220+
// FIXME: we should add it to ignored nodes instead if we want to support blocking the rolling restart.
221+
klog.V(2).InfoS("Node has already been bootstrapped, assuming it's being rolling restarted. Skipping.", "Service", naming.ManualRef(o.Namespace, o.ServiceName), "Bootstrapped", o.bootstrapped, "HostID", o.hostID)
222+
return nil
220223
}
221224
//
222225

0 commit comments

Comments
 (0)