fix: render shapes unannotated by the table with na_color instead of dropping them (#710)

render_shapes joined the element to its table with how="inner", silently dropping shapes whose
instance had no table row. Points (how="left" merge) and labels (raster + na_color) keep unannotated
elements, so shapes were the inconsistent outlier (and it broke the labels<->shapes interchangeability).

Switch _join_table_for_element to how="left": all shapes survive, and the per-shape color lookup
(_extract_color_column, reindexed to the element) yields NaN -> na_color for the unannotated ones, via
the existing NaN-handling path. Fully-annotated data is unaffected (verified pixel-identical: inner == left
when nothing is dropped), so only partial-annotation output changes.

Adds a regression test (fails on the old drop behavior: 12/20 rendered; passes now: 20/20 with 8 na_color).

Author: timtreis

src/spatialdata_plot/pl/utils.py

@@ -444,7 +444,12 @@ def _join_table_for_element(
     element: str,
     table_name: str,
 ) -> tuple[Any, AnnData]:
-    """Inner-join ``element`` with its annotating ``table_name``.
+    """Left-join ``element`` with its annotating ``table_name``.
+
+    A left join keeps every shape, including those without a table row (they get no color value and
+    are rendered with ``na_color``), matching the points/labels behaviour instead of silently dropping
+    unannotated shapes. Colors are resolved per shape downstream and aligned by instance id, so the
+    table need not have a row for every shape.
 
     Wraps the workaround for scverse/spatialdata#1099: ``join_spatialelement_table``
     calls ``table.obs.reset_index()`` which fails when the obs index name matches
@@ -470,7 +475,7 @@ def _join_table_for_element(
 
     try:
         element_dict, joined_table = join_spatialelement_table(
-            sdata, spatial_element_names=element, table_name=table_name, how="inner"
+            sdata, spatial_element_names=element, table_name=table_name, how="left"
         )
     finally:
         if _saved_index is not None:

tests/pl/test_render_shapes.py

@@ -439,6 +439,35 @@ def test_render_shapes_raises_for_missing_column_in_table(self, sdata_blobs_shap
                 element="blobs_polygons", color="not_a_column", table_name="table"
             )
 
+    def test_render_shapes_unannotated_shapes_get_na_color_not_dropped(self):
+        # Regression test for #710: shapes whose instance is not in the annotating table must render
+        # with na_color, not be silently dropped (consistent with the points/labels paths).
+        from matplotlib.colors import to_rgba
+
+        rng = np.random.default_rng(0)
+        n = 20
+        geom = gpd.GeoDataFrame(
+            {"geometry": [Point(*xy) for xy in rng.random((n, 2)) * 100], "radius": np.ones(n) * 2},
+            index=pd.Index(range(n)),
+        )
+        adata = AnnData(  # only the first 12 of 20 shapes are annotated
+            X=rng.random((12, 2)).astype("float32"),
+            obs=pd.DataFrame({"region": pd.Categorical(["shapes"] * 12), "instance_id": np.arange(12), "val": rng.random(12)}),
+        )
+        adata.var_names = ["g0", "g1"]
+        sdata = SpatialData(
+            shapes={"shapes": ShapesModel.parse(geom)},
+            tables={"t": TableModel.parse(adata, region="shapes", region_key="region", instance_key="instance_id")},
+        )
+        fig, ax = plt.subplots()
+        sdata.pl.render_shapes("shapes", color="val", na_color="red").pl.show(ax=ax)
+        fig.canvas.draw()
+        facecolors = ax.collections[0].get_facecolors()
+        plt.close(fig)
+        assert len(facecolors) == n, f"expected all {n} shapes rendered, got {len(facecolors)} (unannotated dropped)"
+        n_na = sum(bool(np.allclose(c, to_rgba("red"))) for c in facecolors)
+        assert n_na == 8, f"expected 8 unannotated shapes in na_color, got {n_na}"
+
     def test_plot_can_plot_shapes_after_spatial_query(self, sdata_blobs: SpatialData):
         # subset to only shapes, should be unnecessary after rasterizeation of multiscale images is included
         blob = SpatialData.init_from_elements(