Skip to content

(doc): centralize PCA docs #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

(doc): centralize PCA docs #3655

merged 4 commits into from
May 28, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented May 28, 2025 •
edited
Loading

  • Release notes not necessary because:

rendered (with diff)

@flying-sheep flying-sheep requested a review from ilan-gold May 28, 2025 09:32
@flying-sheep flying-sheep self-assigned this May 28, 2025
@flying-sheep flying-sheep added this to the 1.11.2 milestone May 28, 2025
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (82adc79) to head (3b6c1a8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3655   +/-   ##
=======================================
  Coverage   76.13%   76.14%           
=======================================
  Files         114      114           
  Lines       12736    12741    +5     
=======================================
+ Hits         9697     9702    +5     
  Misses       3039     3039
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_pca/__init__.py 88.44% <ø> (ø)

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep changed the title Centralize PCA docs (doc): centralize PCA docs May 28, 2025
ilan-gold
ilan-gold reviewed May 28, 2025
View reviewed changes
@flying-sheep flying-sheep force-pushed the pa/pca-docs-overhaul branch from d23c0e2 to 3b6c1a8 Compare May 28, 2025 11:11
@flying-sheep flying-sheep requested a review from ilan-gold May 28, 2025 11:13
@Intron7
Copy link
Member

Intron7 commented May 28, 2025

LGTM

@flying-sheep flying-sheep removed the request for review from ilan-gold May 28, 2025 12:13
@flying-sheep flying-sheep merged commit 207245a into main May 28, 2025
14 checks passed
@flying-sheep flying-sheep deleted the pa/pca-docs-overhaul branch May 28, 2025 12:13
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request May 28, 2025
@flying-sheep @meeseeksmachine
Backport PR scverse#3655: (doc): centralize PCA docs
d2bc1dd
@meeseeksmachine meeseeksmachine mentioned this pull request May 28, 2025
Merged
flying-sheep added a commit that referenced this pull request May 28, 2025
@meeseeksmachine @flying-sheep
Backport PR #3655: (doc): centralize PCA docs (#3660)
178beb0 
Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilan-gold ilan-gold ilan-gold left review comments

Assignees

@flying-sheep flying-sheep

Labels
Area - Documentation 📒
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.

Improve pca documentation
3 participants
@flying-sheep @Intron7 @ilan-gold