Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify scale #3351

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Simplify scale #3351

wants to merge 10 commits into from

Conversation

flying-sheep
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (6dd0a7a) to head (f57a9b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
- Coverage   76.58%   76.58%   -0.01%     
==========================================
  Files         111      111              
  Lines       12862    12831      -31     
==========================================
- Hits         9850     9826      -24     
+ Misses       3012     3005       -7     
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_scale.py 79.41% <100.00%> (+0.46%) ⬆️

Copy link

scverse-benchmark bot commented Nov 11, 2024

Benchmark changes

Change Before [6dd0a7a] After [f57a9b0] Ratio Benchmark (Parameter)
- 597M 516M 0.87 preprocessing_log.peakmem_pca('pbmc3k', 'off-axis')
- 438M 329M 0.75 preprocessing_log.peakmem_pca('pbmc68k_reduced', 'off-axis')
+ 941M 1.29G 1.38 preprocessing_log.peakmem_scale('pbmc3k', 'off-axis')
+ 1.14G 1.49G 1.31 preprocessing_log.peakmem_scale('pbmc3k', None)
- 754±20ms 489±30ms 0.65 preprocessing_log.time_scale('pbmc3k', 'off-axis')
- 728±2ms 540±4ms 0.74 preprocessing_log.time_scale('pbmc3k', None)

Comparison: https://github.com/scverse/scanpy/compare/6dd0a7a72c7f8f57a082cca0f6a369dc47937b04..f57a9b0b4c3a60876ca2682f89729063ab0ca18b
Last changed: Mon, 11 Nov 2024 16:18:52 +0000

More details: https://github.com/scverse/scanpy/pull/3351/checks?check_run_id=32808644368

@flying-sheep flying-sheep changed the title Simplify-scale Simplify scale Nov 11, 2024
@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.12.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant