Simplify scale #3351
Merged
Simplify scale #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
force-pushed
the
simplify-scale
branch
from
f546c5e to
f57a9b0
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
==========================================
- Coverage 76.68% 76.68% -0.01%
==========================================
Files 113 113
Lines 12735 12709 -26
==========================================
- Hits 9766 9746 -20
+ Misses 2969 2963 -6
|
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/c2a7a4b7ec3203121a8d75aa05fbeb602ceecbd4..a5caa39435fa9b5c1c88cea9cce904ca813757d7 More details: https://github.com/scverse/scanpy/pull/3351/checks?check_run_id=42303504284 |
for more information, see https://pre-commit.ci
selmanozleyen
pushed a commit
that referenced
this pull request
May 19, 2025
Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ilan-gold
added a commit
that referenced
this pull request
May 19, 2025
* update normalize_total & remove dep * refactor: `normalize_total` with Numba (#3593) Co-authored-by: Philipp A. <flying-sheep@web.de> * fix doctest * add release note * Switch from profimp to tuna for parsing import profiles (#3620) * [pre-commit.ci] pre-commit autoupdate (#3622) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Philipp A. <flying-sheep@web.de> * Fix typo (#3555) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Switch to fast-array-utils (#3598) Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> * tSNE components parameter (#2803) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Simplify scale (#3351) Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove layers test * explicit return and fix the info message * remove unnecessary ravel's * precision fix * (fix): maintain data type properly. * (fix): remove artifact storage * (refactor): use nice f-a-u typing --------- Co-authored-by: Philipp A. <flying-sheep@web.de> Co-authored-by: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com> Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> Co-authored-by: Kitsune <48340051+ch1ru@users.noreply.github.com> Co-authored-by: selmanozleyen <syozleyen@gmail.com> Co-authored-by: ilan-gold <ilanbassgold@gmail.com>
ilan-gold
pushed a commit
that referenced
this pull request
May 20, 2025
ilan-gold
added a commit
that referenced
this pull request
May 20, 2025
* Backport PR #3351: Simplify scale * (fix): try register * (fix): one more missing register --------- Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scale_sparsehas a lot of code that’s not needed.This PR also fixes zappy compatibility for
scale, not that anyone is using it as far as I know.