Skip to content

(feat): add n_components parameter to tSNE #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025
Merged

Conversation

ch1ru
Copy link
Contributor

@ch1ru ch1ru commented Jan 11, 2024

Added the n_components parameter in the tsne function, similar to the one in umap and updated docstring.

  • Release notes not necessary because: Only minor change.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.84%. Comparing base (c410cd1) to head (88d721c).
Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2803   +/-   ##
=======================================
  Coverage   72.84%   72.84%           
=======================================
  Files         111      111           
  Lines       12368    12368           
=======================================
  Hits         9009     9009           
  Misses       3359     3359           
Files Coverage Δ
scanpy/tools/_tsne.py 90.69% <ø> (ø)

@flying-sheep flying-sheep added this to the 1.12.0 milestone May 8, 2025
@flying-sheep
Copy link
Member

Thanks!

@flying-sheep flying-sheep enabled auto-merge (squash) May 8, 2025 11:07
@flying-sheep flying-sheep changed the title tSNE components parameter (feat): add n_components parameter to tSNE May 8, 2025
@flying-sheep flying-sheep merged commit c2a7a4b into scverse:main May 15, 2025
16 of 17 checks passed
selmanozleyen pushed a commit that referenced this pull request May 19, 2025
Co-authored-by: Phil Schaf <flying-sheep@web.de>
ilan-gold added a commit that referenced this pull request May 19, 2025
* update normalize_total & remove dep

* refactor: `normalize_total` with Numba (#3593)

Co-authored-by: Philipp A. <flying-sheep@web.de>

* fix doctest

* add release note

* Switch from profimp to tuna for parsing import profiles (#3620)

* [pre-commit.ci] pre-commit autoupdate (#3622)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Philipp A. <flying-sheep@web.de>

* Fix typo (#3555)

Co-authored-by: Phil Schaf <flying-sheep@web.de>

* Switch to fast-array-utils (#3598)

Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>

* tSNE components parameter (#2803)

Co-authored-by: Phil Schaf <flying-sheep@web.de>

* Simplify scale (#3351)

Co-authored-by: Intron7 <severin.dicks@icloud.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove layers test

* explicit return and fix the info message

* remove unnecessary ravel's

* precision fix

* (fix): maintain data type properly.

* (fix): remove artifact storage

* (refactor): use nice f-a-u typing

---------

Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com>
Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
Co-authored-by: Kitsune <48340051+ch1ru@users.noreply.github.com>
Co-authored-by: selmanozleyen <syozleyen@gmail.com>
Co-authored-by: ilan-gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional parameters in some functions - new functions
2 participants