Skip to content

Add sum #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 18, 2025
Merged

Add sum #13

merged 12 commits into from
Feb 18, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jan 28, 2025

Hi @ilan-gold you implemented the dask support here, but I have a few questions, could you please take a look?

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (f241148) to head (fbd1d7d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fast_array_utils/stats/_sum.py 78.57% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   77.34%   78.03%   +0.69%     
==========================================
  Files           7        9       +2     
  Lines         128      173      +45     
==========================================
+ Hits           99      135      +36     
- Misses         29       38       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #13 will not alter performance

Comparing pa/sum (fbd1d7d) with main (f241148)

Summary

✅ 8 untouched benchmarks
🆕 30 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_sum_benchmark[numpy.ndarray-0-float32] N/A 106.7 µs N/A
🆕 test_sum_benchmark[numpy.ndarray-0-float64] N/A 127.9 µs N/A
🆕 test_sum_benchmark[numpy.ndarray-1-float32] N/A 111.6 µs N/A
🆕 test_sum_benchmark[numpy.ndarray-1-float64] N/A 130.6 µs N/A
🆕 test_sum_benchmark[numpy.ndarray-None-float32] N/A 107 µs N/A
🆕 test_sum_benchmark[numpy.ndarray-None-float64] N/A 125.2 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-0-float32] N/A 314.7 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-0-float64] N/A 338.2 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-1-float32] N/A 273.9 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-1-float64] N/A 299.9 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-None-float32] N/A 268.9 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_array-None-float64] N/A 290.9 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-0-float32] N/A 374.7 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-0-float64] N/A 400.6 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-1-float32] N/A 338.2 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-1-float64] N/A 366 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-None-float32] N/A 336.3 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csc_matrix-None-float64] N/A 353.1 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csr_array-0-float32] N/A 411.6 µs N/A
🆕 test_sum_benchmark[scipy.sparse.csr_array-0-float64] N/A 438.3 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@flying-sheep flying-sheep assigned ilan-gold and unassigned ilan-gold Jan 28, 2025
@flying-sheep flying-sheep mentioned this pull request Feb 18, 2025
@flying-sheep flying-sheep merged commit a33cf9a into main Feb 18, 2025
11 checks passed
@flying-sheep flying-sheep deleted the pa/sum branch February 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants