bump substrate to polkadot-v0.9.2. + add GA + re-add branch ids #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his crate into a separate trait to emphasize that they are not from substrate.
…l in std somewhere.
…est `cargo build --examples` - works
brenzi
suggested changes
May 24, 2021
|
yes, wasm-toochail was not installed for the clippy runner. Anyhow. Please don't merge yet. It currently depends on the encointer fork of the |
clangenb
changed the title
clangenb
changed the title
brenzi
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale Branch Ids:
Polkadot references substrate dependencies including
branch = "master". Hence, any rust crate that uses substrate AND Polkadot deps must use the branch-id because Cargo can't identify them as the same even if the same substrate revision is referenced.This is the api-client branch that is currently used with the encointer-client.