Draft: MRENCLAVE support antehandler #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboh4
requested review from
Cashmaney,
toml01,
liorbond and
valdok
as code owners
Now MREnclaveHash resides in the "Plan.info" field of the MsgSoftwareUpgrade message. We find the latest passed proposal and extract MREnclaveHash from there.
quaisx
reviewed
Sep 17, 2024
| // verifyUpgradeProposal verifies the latest passed upgrade proposal to ensure the MREnclave hash matches. | ||
| func (a *CountTXDecorator) verifyUpgradeProposal(ctx sdk.Context, msgUpgrade *types.MsgUpgradeProposalPassed) error { | ||
| iterator, err := a.govkeeper.Proposals.Iterate(ctx, nil) | ||
| if err != nil { |
There was a problem hiding this comment.
ctx.Logger().Error(fmt.Sprintf("Governance Keeper Proposal: %s", err))
No need to use ! sign.
x/compute/internal/keeper/ante.go
Outdated
| func (a *CountTXDecorator) verifyUpgradeProposal(ctx sdk.Context, msgUpgrade *types.MsgUpgradeProposalPassed) error { | ||
| iterator, err := a.govkeeper.Proposals.Iterate(ctx, nil) | ||
| if err != nil { | ||
| ctx.Logger().Error("Failed to get the iterator of proposals!", err.Error()) |
There was a problem hiding this comment.
You may want to return the actual error
x/compute/internal/keeper/ante.go
Outdated
| var latestMREnclaveHash string | ||
|
|
||
| // Iterate through the proposals | ||
| for ; iterator.Valid(); iterator.Next() { |
There was a problem hiding this comment.
you should use for range iterator construct
x/compute/internal/keeper/ante.go
Outdated
| proposal, err := iterator.Value() | ||
| if err != nil { | ||
| ctx.Logger().Error("Failed to get the proposal from iterator!", err.Error()) | ||
| return errors.New("Failed to get the proposal from iterator!") |
There was a problem hiding this comment.
user fmt.Errorf. No need to use ! sign
x/compute/internal/keeper/ante.go
Outdated
| } | ||
| // Check if the proposal has passed and is of type MsgSoftwareUpgrade | ||
| if proposal.Status == v1.ProposalStatus_PROPOSAL_STATUS_PASSED { | ||
| if len(proposal.GetMessages()) > 0 && proposal.Messages[0].GetTypeUrl() == "/cosmos.upgrade.v1beta1.MsgSoftwareUpgrade" { |
There was a problem hiding this comment.
Please use a const for "/cosmos.upgrade.v1beta1.MsgSoftwareUpgrade"
iKapitonau
force-pushed
the
cosmos-sdk-0.50.x-merged
branch
from
1857d07 to
a95b51a
Compare
iKapitonau
force-pushed
the
cosmos-sdk-0.50.x-merged
branch
from
8f32ac2 to
405cbc0
Compare
valdok
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.