Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@DreamWuGit
Copy link

Description

[PR description]

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc lispc marked this pull request as ready for review September 15, 2023 14:21
@lispc
Copy link

lispc commented Sep 16, 2023

at least need to assign the poseidon table inside mpt circuit ...

@lispc
Copy link

lispc commented Sep 16, 2023

@z2trillion i think we'd better fix here. So later we can use the TextContext framework to test any bytecode with mpt circuit inside this repo.

@z2trillion z2trillion force-pushed the mpt__non_existing_address branch from dab1767 to 14cde4e Compare September 18, 2023 18:28
@lispc lispc changed the title Mpt transfer non zero value to non existing address test(mpt circuit): transfer eth to non existing address Sep 20, 2023
@lispc lispc merged commit ea5e17a into develop Sep 20, 2023
@lispc lispc deleted the mpt__non_existing_address branch September 20, 2023 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants