ecrecover soundness (address not recovered)

[roynalnaruto]

Description

Ecrecover "address not recovered" case to be supported by SigCircuit.

Key Changes

• SigCircuit processes all ecrecover inputs except:
  • sig_r overflowing (not canonical)
  • sig_s overflowing (not canonical)
  • sig_v is invalid, i.e. sig_v != 27 && sig_v != 28
  • The 2 above cases are handled directly in EVM circuit by the ecrecover gadget
• We add more tests for SigCircuit to check panic issues because of these edge cases
  • msg_hash == 0
  • sig_r == 0
  • sig_s == 0
  • address could not be recovered
• EVM Circuit's ecrecover gadget does a lookup to SigTable in all cases except:
  • sig_r overflowing (not canonical)
  • sig_s overflowing (not canonical)
  • sig_v is invalid, i.e. sig_v != 27 && sig_v != 28

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

[lispc]

we may need to change the par_bridge into something like this

TEST_VECTOR
    .par_iter() // parallelize TEST_VECTOR
    .for_each(|test| {
        for kind in &call_kinds {
            // call_kinds is sequential
            test_one(test, kind); 
        }
    });