Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@kunxian-xia
Copy link

Description

We split the row usage of tx into two category and ask pi circuit to do one measurement.

Issue Link

The ccc requirement of adding new txs includes

  1. txs.len() < MAX_TXS;
  2. length of txs' call data bytes must be less than MAX_CALLDATA.

To meet the requirement we use

max(txs.len() / MAX_TXS, call_data_bytes.len() / MAX_CALLDATA)

This method may cause low usage of tx table. Here is an example (let's say MAX_TXS = 100, MAX_CALLDATA= 128k):

tx t1's call_data_length is quite large, e.g. 12k, then it will cost about 10% of row capacity. It means that the block can only hold 91 txs even the others only have very few call data bytes.

Type of change

  • Improvement
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@lispc lispc merged commit e7d4c10 into develop Sep 1, 2023
@lispc lispc deleted the fix/tx-pi-ccc branch September 1, 2023 00:53
Velaciela added a commit that referenced this pull request Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants