Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

testool: support sub circuit; fix modexp row usage #841

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 29, 2023

Description

[PR description]

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc lispc changed the title testool: support sub circuit testool: support sub circuit; fix modexp row usage Aug 29, 2023
@lispc lispc merged commit 5134be1 into develop Aug 29, 2023
@lispc lispc deleted the feat/testool/subcircuit branch August 29, 2023 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant