This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Move external-tracer from bus-mapping to a new crate only for test
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
approved these changes
Jan 24, 2022
Comment on lines
+10
to
+20
| /// Mock chain ID | ||
| pub const MOCK_CHAIN_ID: u64 = 1338; | ||
|
|
||
| /// Mock gas | ||
| pub const MOCK_GAS: u64 = 1_000_000u64; | ||
|
|
||
| lazy_static! { | ||
| /// Mock coinbase value | ||
| pub static ref MOCK_COINBASE: Address = | ||
| address!("0x00000000000000000000000000000000c014ba5e"); | ||
| } |
There was a problem hiding this comment.
these seem for mocking. can we move these to mock?
| /// with the given gas limit. | ||
| /// The trace will be generated automatically with the external_tracer | ||
| /// from the accounts code. | ||
| pub fn create_tx_by_accounts( |
There was a problem hiding this comment.
can we move create_tx_by_accounts create_tx_by_steps new_tx new_block and new_chain_constants to mock?
because they seem mock-specific.
and in mock::create_tx_by_accounts we can call external_tracer::trace
0xmountaintop
approved these changes
Jan 24, 2022
|
moved to privacy-scaling-explorations#303 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #61
Close privacy-scaling-explorations#272
Summary
etc-types/src/geth_types.rs.bus_mapping::mock::BlockDatato test implement (commented with#[cfg(test)]) and common implement (exported for test of zkevm-circuit).