This repository was archived by the owner on Apr 18, 2025. It is now read-only.
fix-exp-is-last: enforce the secure termination of Exp circuit #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\b run testool |
|
Succeed to run testool: |
Merged
* simplify-exp-lookup: remove unnecessary Exp lookup * simplify-exp-lookup: Remove identifier and is_last from Exp lookup * simplify-exp-lookup: Remove identifier from the Exp circuit --------- Co-authored-by: Aurélien Nicolas <info@nau.re>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://app.asana.com/0/1203078612788501/1205364106497215/f
The circuit relies on checks when
is_last=1. However, there is no guarantee that a rowis_last=1will be reached. In particular, the processing of an event can reach the end of the circuit before validating all steps. This is confirmed by an exploit.Same issue and same solution as in the MPT circuit: scroll-tech/mpt-circuit#85