Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

fix code_size in create; fix return_data for call oog #826

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 25, 2023

Description

[PR description]

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc
Copy link
Author

lispc commented Aug 25, 2023

\b run testool 1

@zkevm-circuits-bots
Copy link

Succeed to run testool:
https://circuit-release.s3.us-west-2.amazonaws.com/testool/

@lispc
Copy link
Author

lispc commented Aug 25, 2023

\b run testool

@silathdiir
Copy link

\b run testool 1

@lispc lispc merged commit 956059f into develop Aug 25, 2023
@lispc lispc deleted the fix/code_size_in_create branch August 25, 2023 13:20
@lispc lispc restored the fix/code_size_in_create branch August 25, 2023 13:20
@zkevm-circuits-bots
Copy link

@zkevm-circuits-bots
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants