This repository was archived by the owner on Apr 18, 2025. It is now read-only.
fix test tool create collision tests #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…croll-tech/zkevm-circuits into fix_test_tool_create_collision
|
\b run testool |
lispc
approved these changes
Aug 18, 2023
|
\b run testool |
|
Succeed to run testool: |
|
Succeed to run testool: |
lispc
approved these changes
Aug 22, 2023
|
let me merge it after ci passes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if creating account once > 0, it is also create address collision error.
fix three tests:
create2collisionNonce_d2_g0_v0
create2collisionNonce_d1_g0_v0
create2collisionNonce_d0_g0_v0
Issue Link
[link issue here]
Type of change
Contents
Rationale
[design decisions and extended information]